feat(1b): Automatische Notfallerkennung raus → manueller Notruf-Knopf
Die unzuverlässige/intransparente Auto-Erkennung (Stichwörter + LLM) ist
ersatzlos entfernt: emergency.py neu (nur manueller, vom Nutzer bestätigter
Notruf), llm_classifier.py gelöscht, Aufrufe in chat.py/ws.py raus,
emergency_llm_* aus der Config.
Neu: prominenter "🆘 Hilfe rufen"-Knopf (Bestätigung) → POST /api/emergency
→ protokolliert + liefert Hinweis in Nutzersprache. Eskalation (Benachrichtigung
an Angehörige) folgt später; vorerst Platzhalter "ACHTUNG: Es ist noch keine
Benachrichtigung eingebaut." (10 Sprachen). Admin-Tab "Notfälle" → "Notrufe".
Tests: test_emergency_llm.py entfernt, test_quota_safety.py auf Notruf-Endpunkt
umgeschrieben. 208 passed. Live verifiziert.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
parent
be5206c7ed
commit
3389f75af0
10 changed files with 112 additions and 433 deletions
|
|
@ -1,128 +0,0 @@
|
|||
import asyncio
|
||||
|
||||
import pytest
|
||||
|
||||
from app.config import settings
|
||||
from app.safety import emergency as em
|
||||
from app.safety import llm_classifier as lc
|
||||
|
||||
|
||||
class StubLLM:
|
||||
def __init__(self, raw):
|
||||
self.raw = raw
|
||||
self.calls = 0
|
||||
|
||||
async def complete(self, text, history=None, session_id=None, language=None):
|
||||
self.calls += 1
|
||||
return self.raw
|
||||
|
||||
|
||||
class FakeUser:
|
||||
id = "anonymous"
|
||||
display_name = "Test"
|
||||
|
||||
|
||||
class FakeStore:
|
||||
def __init__(self):
|
||||
self.logged = []
|
||||
|
||||
def log_emergency(self, user_id, category, snippet):
|
||||
self.logged.append((user_id, category, snippet))
|
||||
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def _clear_pending():
|
||||
em._pending.clear()
|
||||
yield
|
||||
em._pending.clear()
|
||||
|
||||
|
||||
def test_parse_classification_variants():
|
||||
assert lc.parse_classification('{"category":"medical","confidence":0.9}')["category"] == "medical"
|
||||
# umschlossen von Text
|
||||
got = lc.parse_classification('Antwort: {"category":"help","confidence":0.7,"reason":"Feuer"}')
|
||||
assert got["category"] == "help" and got["confidence"] == 0.7
|
||||
# 'none' ist kein Notfall
|
||||
assert lc.parse_classification('{"category":"none","confidence":0.99}') is None
|
||||
# unbekannte Kategorie
|
||||
assert lc.parse_classification('{"category":"foo","confidence":0.99}') is None
|
||||
assert lc.parse_classification("kein json") is None
|
||||
assert lc.parse_classification("") is None
|
||||
|
||||
|
||||
def test_classify_respects_confidence_threshold(monkeypatch):
|
||||
monkeypatch.setattr(settings, "emergency_llm_min_confidence", 0.6)
|
||||
monkeypatch.setattr(lc, "_build_classifier_llm",
|
||||
lambda cfg: StubLLM('{"category":"medical","confidence":0.4}'))
|
||||
# unter der Schwelle -> kein Notfall
|
||||
assert asyncio.run(lc.classify_emergency("mir ist schwindelig")) is None
|
||||
|
||||
monkeypatch.setattr(lc, "_build_classifier_llm",
|
||||
lambda cfg: StubLLM('{"category":"medical","confidence":0.85}'))
|
||||
res = asyncio.run(lc.classify_emergency("mir wird ganz schwarz vor augen"))
|
||||
assert res["category"] == "medical"
|
||||
|
||||
|
||||
def test_schedule_skips_when_keyword_already_hit(monkeypatch):
|
||||
store = FakeStore()
|
||||
called = StubLLM('{"category":"medical","confidence":0.9}')
|
||||
monkeypatch.setattr(lc, "_build_classifier_llm", lambda cfg: called)
|
||||
|
||||
async def run():
|
||||
# keyword_hit ist gesetzt -> Stufe 2 wird uebersprungen
|
||||
task = em.schedule_llm_emergency_check(
|
||||
FakeUser(), "egal", store, {"category": "medical", "matched": "x"}
|
||||
)
|
||||
return task
|
||||
|
||||
assert asyncio.run(run()) is None
|
||||
assert called.calls == 0
|
||||
assert store.logged == []
|
||||
|
||||
|
||||
def test_schedule_disabled_is_noop(monkeypatch):
|
||||
monkeypatch.setattr(settings, "emergency_llm_enabled", False)
|
||||
store = FakeStore()
|
||||
|
||||
async def run():
|
||||
return em.schedule_llm_emergency_check(FakeUser(), "hilfe", store, None)
|
||||
|
||||
assert asyncio.run(run()) is None
|
||||
assert store.logged == []
|
||||
|
||||
|
||||
def test_schedule_escalates_and_calls_callback(monkeypatch):
|
||||
monkeypatch.setattr(settings, "emergency_llm_enabled", True)
|
||||
monkeypatch.setattr(settings, "emergency_llm_min_confidence", 0.6)
|
||||
monkeypatch.setattr(lc, "_build_classifier_llm",
|
||||
lambda cfg: StubLLM('{"category":"self_harm","confidence":0.95}'))
|
||||
store = FakeStore()
|
||||
events = []
|
||||
|
||||
async def on_emergency(category):
|
||||
events.append(category)
|
||||
|
||||
async def run():
|
||||
task = em.schedule_llm_emergency_check(
|
||||
FakeUser(), "ich will nicht mehr weiterleben",
|
||||
store, None, on_emergency=on_emergency,
|
||||
)
|
||||
await task
|
||||
|
||||
asyncio.run(run())
|
||||
assert store.logged == [("anonymous", "self_harm", "ich will nicht mehr weiterleben")]
|
||||
assert events == ["self_harm"]
|
||||
|
||||
|
||||
def test_schedule_malformed_output_no_escalation(monkeypatch):
|
||||
monkeypatch.setattr(settings, "emergency_llm_enabled", True)
|
||||
monkeypatch.setattr(lc, "_build_classifier_llm",
|
||||
lambda cfg: StubLLM("Tut mir leid, kein JSON."))
|
||||
store = FakeStore()
|
||||
|
||||
async def run():
|
||||
task = em.schedule_llm_emergency_check(FakeUser(), "irgendwas", store, None)
|
||||
await task
|
||||
|
||||
asyncio.run(run())
|
||||
assert store.logged == []
|
||||
|
|
@ -3,7 +3,6 @@ from fastapi.testclient import TestClient
|
|||
import app.dependencies as deps
|
||||
from app.main import app
|
||||
from app.config import settings
|
||||
from app.safety.emergency import detect
|
||||
|
||||
client = TestClient(app)
|
||||
|
||||
|
|
@ -22,16 +21,6 @@ def _stub_chat(monkeypatch, answer="ok"):
|
|||
return {"llm_provider": "l", "tts_provider": "t"}
|
||||
|
||||
|
||||
# --- Notfall-Erkennung (Einheit) ------------------------------------------
|
||||
|
||||
def test_detect_categories():
|
||||
assert detect("Ich habe Brustschmerzen")[0] == "medical"
|
||||
assert detect("Bitte ruf einen Arzt")[0] == "help"
|
||||
assert detect("I want to die")[0] == "self_harm"
|
||||
assert detect("Wie wird das Wetter morgen?") is None
|
||||
assert detect("") is None
|
||||
|
||||
|
||||
# --- Quota -----------------------------------------------------------------
|
||||
|
||||
def test_quota_blocks_after_limit(monkeypatch):
|
||||
|
|
@ -49,33 +38,29 @@ def test_quota_unlimited_by_default(monkeypatch):
|
|||
assert client.post("/api/chat?debug=true", json=body).status_code == 200
|
||||
|
||||
|
||||
# --- Notfall ueber Endpunkt ------------------------------------------------
|
||||
# --- Manueller Notruf (vom Nutzer ausgelöst) -------------------------------
|
||||
|
||||
def test_emergency_surfaced_in_response(monkeypatch):
|
||||
base = _stub_chat(monkeypatch, answer="Bleiben Sie ruhig.")
|
||||
resp = client.post(
|
||||
"/api/chat?debug=true",
|
||||
json={"text": "Ich habe starke Schmerzen in der Brust", **base},
|
||||
)
|
||||
def test_manual_emergency_logs_and_returns_localized_notice():
|
||||
resp = client.post("/api/emergency", json={"language": "de"})
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["emergency"]["category"] == "medical"
|
||||
data = resp.json()
|
||||
assert data["category"] == "manual"
|
||||
assert "noch keine Benachrichtigung" in data["notice"]
|
||||
# Notruf wurde protokolliert
|
||||
events = deps.get_store().list_emergency_events(10)
|
||||
assert any(e["category"] == "manual" for e in events)
|
||||
|
||||
|
||||
def test_emergency_bypasses_quota(monkeypatch):
|
||||
base = _stub_chat(monkeypatch)
|
||||
def test_manual_emergency_notice_language_fallback():
|
||||
# Unbekannte Sprache -> deutscher Fallback-Hinweis
|
||||
en = client.post("/api/emergency", json={"language": "en"}).json()["notice"]
|
||||
assert "ATTENTION" in en
|
||||
xx = client.post("/api/emergency", json={"language": "xx"}).json()["notice"]
|
||||
assert "ACHTUNG" in xx
|
||||
|
||||
|
||||
def test_manual_emergency_does_not_count_against_quota(monkeypatch):
|
||||
# Der Notruf-Endpunkt ist von der Chat-Quota unabhängig.
|
||||
monkeypatch.setattr(settings, "daily_request_limit", 1)
|
||||
body = {**base}
|
||||
assert client.post("/api/chat?debug=true", json={"text": "hallo", **body}).status_code == 200
|
||||
assert client.post("/api/chat?debug=true", json={"text": "hallo", **body}).status_code == 429
|
||||
rescue = client.post("/api/chat?debug=true", json={"text": "ich kann nicht atmen", **body})
|
||||
assert rescue.status_code == 200
|
||||
assert rescue.json()["emergency"]["category"] == "medical"
|
||||
|
||||
|
||||
def test_ws_emergency_event(monkeypatch):
|
||||
base = _stub_chat(monkeypatch, answer="Ruhig bleiben, Hilfe kommt.")
|
||||
with client.websocket_connect("/ws/chat") as ws:
|
||||
ws.send_json({"text": "Ich bin gestürzt und komme nicht hoch", **base})
|
||||
event = ws.receive_json()
|
||||
assert event["type"] == "emergency" and event["category"] == "medical"
|
||||
assert ws.receive_json()["type"] == "ack"
|
||||
for _ in range(3):
|
||||
assert client.post("/api/emergency", json={"language": "de"}).status_code == 200
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue