dschlueter/Musiksammlung
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove MusicBrainz retry logic — HTTP 200 means no data, not transient error

Browse source 
MusicBrainz always returns HTTP 200; an empty result set is definitive.
Retrying would never yield a different outcome.

- lookup_by_barcode(): retries parameter removed, random import removed
- Removed 3 retry-related tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Dieter Schlüter 2026-02-18 09:48:07 +01:00
commit 2f80cb2693
2 changed files with 11 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

35
tests/test_musicbrainz.py
View file

@ -171,42 +171,9 @@ class TestLookupByBarcode:
with (
patch("musiksammlung.musicbrainz.httpx.get", return_value=empty),
patch("musiksammlung.musicbrainz.time.sleep"),
patch("musiksammlung.musicbrainz.random.uniform", return_value=0.0),
pytest.raises(ValueError, match="Kein MusicBrainz-Eintrag"),
):
lookup_by_barcode("0000000000000", retries=0)
def test_retries_on_empty_result(self) -> None:
"""Bei leerem Ergebnis wird bis zu retries-mal wiederholt."""
empty = _mock_response({"releases": []})
hit = _mock_response(_BARCODE_RESPONSE)
# Erste zwei Versuche leer, dritter Versuch Treffer
responses = [empty, empty, hit, _mock_response(_RELEASE_RESPONSE)]
with (
patch("musiksammlung.musicbrainz.httpx.get", side_effect=responses) as mock_get,
patch("musiksammlung.musicbrainz.time.sleep"),
patch("musiksammlung.musicbrainz.random.uniform", return_value=0.0),
):
album = lookup_by_barcode("0602557360561", retries=3)
assert album.artist == "The Beatles"
# 3 Barcode-Requests + 1 Release-Request
assert mock_get.call_count == 4
def test_retry_sleep_is_called_between_attempts(self) -> None:
"""Zwischen den Versuchen wird time.sleep aufgerufen."""
empty = _mock_response({"releases": []})
responses = [empty, _mock_response(_BARCODE_RESPONSE), _mock_response(_RELEASE_RESPONSE)]
with (
patch("musiksammlung.musicbrainz.httpx.get", side_effect=responses),
patch("musiksammlung.musicbrainz.time.sleep") as mock_sleep,
patch("musiksammlung.musicbrainz.random.uniform", return_value=2.5),
):
lookup_by_barcode("0602557360561", retries=2)
# Einmal Retry-Sleep (2.5 s) + einmal Rate-Limit-Sleep (≥1.1 s)
assert mock_sleep.call_count == 2
assert mock_sleep.call_args_list[0][0][0] == 2.5
lookup_by_barcode("0000000000000")
def test_uses_first_release(self) -> None:
barcode_data = {"releases": [{"id": "first-id"}, {"id": "second-id"}]}